Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup for Archive PyCon TW 2023 #459

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Setup for Archive PyCon TW 2023 #459

merged 4 commits into from
Dec 19, 2023

Conversation

rockleona
Copy link
Contributor

Types of changes

  • Breaking change
    • Archive PyCon TW 2023
    • Setup as "static" mode to generate static files
    • All dispatch method are changed into async asyncData()

@netlify Netlify
Copy link

netlify bot commented Dec 9, 2023 •
edited
Loading

❌ Deploy Preview for ephemeral-sable-89c7e0 failed.

Name Link
🔨 Latest commit 785ddd1
🔍 Latest deploy log https://app.netlify.com/sites/ephemeral-sable-89c7e0/deploys/657da73874c1ec00083e4c1e

@rockleona
Copy link
Contributor Author

@josix , could you help me out due to some possible misconfiguration that can not build specific pages.

@josix josix marked this pull request as ready for review December 12, 2023 13:56
@josix josix requested a review from baby230211 December 12, 2023 14:14
@josix
Copy link
Collaborator

josix commented Dec 12, 2023

It works well on my laptop and netlify, I think we could go on to review it. @baby230211 could you help review it, thanks!

@rockleona
Copy link
Contributor Author

Hi @josix and @baby230211, I found a misplaced component venueMap in pages, already moved it under components.

Also I re-generate the code again and it works, probably I used the wrong Auth_Token last time, thanks to Josix for helping me out.

josix
josix requested changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@josix josix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rockleona seems there are some ci issues need to be fixed cloud you help fix it, thanks!

@rockleona
Copy link
Contributor Author

Hi @josix, I already fix the linter error and seems like it's solved, please check.

@rockleona rockleona requested a review from josix December 13, 2023 08:09
@baby230211
Copy link
Collaborator

baby230211 commented Dec 15, 2023 •
edited
Loading

This comment is just to mention previous related PR and issue for this same feature.
#388
#380

@rockleona rockleona requested a review from baby230211 December 16, 2023 13:33
baby230211
baby230211 approved these changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@baby230211 baby230211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josix josix merged commit 0293e46 into pycontw:main Dec 19, 2023
1 check passed
@josix
Copy link
Collaborator

josix commented Dec 19, 2023

Thanks @rockleona! BTW, could you help follow the instruction to archive the 2023 site and upload it to pycon_archive_past_website.

@rockleona rockleona mentioned this pull request Dec 20, 2023
Closed
@rockleona rockleona mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baby230211 baby230211 baby230211 approved these changes

@josix josix josix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rockleona @josix @baby230211